fix no data message may not be shown when deleteLogs is enabled #14526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
reviewed
Jun 14, 2019
| return; | ||
| } | ||
|
|
||
| if (self::hasTrackedAnyTraffic($siteId)) { | ||
| if (!self::hasTrackedAnyTraffic($siteId)) { |
There was a problem hiding this comment.
delete_logs_enable can be turned on/off, correct? Should we set the above option here too?
There was a problem hiding this comment.
👍 pushing it now. That should make it a lot simpler
|
One more comment: is there a way to make this change visible in tests? |
|
Going to add some tests myself then merge |
|
Thank you very much @diosmosis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SitesManager::hasTrackedAnyTraffic($idSite)was returning inverted result. Meaning it was returning true when no traffic was tracked, but the method suggested it should return false in this case.