Adds new ViewDataTable.configure.end event #14355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing a plugin I tried to add a footer message to an existing report when the report is shown flattened. I tried that using the event
ViewDataTable.configure
with following code.I wondered why that worked when switching to the flattened view, but not after reloading the page (having the report still flattened).
The reason is, that the saved viewdata parameters are injected after the event is posted. That means that
$view->requestConfig->flat
holds the default valuefalse
until then.My expectations would have been, that the event already gets the final parameters. If that's wrong maybe we could add a new event
ViewDataTable.configure.end
or similar that works with the final parameters?ping @tsteur @diosmosis @mattab