Real time map dialog box does not close with x · Issue #15404 · matomo-org/matomo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Real time map dialog box does not close with x #15404

Closed
plegault3397 opened this issue Jan 16, 2020 · 4 comments · Fixed by #15443
Closed

Real time map dialog box does not close with x #15404

plegault3397 opened this issue Jan 16, 2020 · 4 comments · Fixed by #15443
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.13.2

Comments

@plegault3397
Copy link

I did upgrade to the new release Matomo 3.13.1
I have seen this before.
When opening the real time map and selecting one of the dots I can review the activity. When I click on the x in the top right corner nothing happens. I can click away from the box and it does close.
@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jan 16, 2020
@tsteur tsteur added this to the 3.13.1 milestone Jan 16, 2020
@tsteur
Copy link
Member

tsteur commented Jan 16, 2020

Indeed this no longer works. It works as a workaround when clicking on the background.

@Findus23 Findus23 mentioned this issue Jan 17, 2020
Closed
@mattab mattab modified the milestones: 3.13.1, 3.13.2 Jan 21, 2020
@tsteur
Copy link
Member

tsteur commented Jan 23, 2020

This is actually not a regression. At least it's not working in 3.13 either and it doesn't look like this has been changed in a while. Will move it into 4.1 release.

The issue seems around https://github.com/matomo-org/matomo/blob/3.13.1/plugins/Live/javascripts/visitorProfile.js#L79

Quickly spent 15 min trying to fix it by adding code like this

                if (self.$element.closest('#Piwik_Popover').length) {
                    Piwik_Popover.close();
                }

but I think this could have side effects maybe. Then thought maybe

                if (self.$element.closest('#Piwik_Popover').length) {
                    self.$element.closest('#Piwik_Popover').dialog('close');
                }

is maybe a better solution but not sure if this would confuse the popover stack etc. Not sure what the best solution is there/

@tsteur tsteur modified the milestones: 3.13.2, 4.1.0 Jan 23, 2020
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 23, 2020
@sgiehl
Copy link
Member

sgiehl commented Jan 23, 2020

@tsteur It's actually easy to fix. The problem is, that when opening the visitor profile from the map it's directly opened within the popover, without using the url hash. In that case a simple Piwik_Popover.close() works. But when the url hash is present (e.g. from visitor log), that shouldn't be done.
I'll prepare a quick fix for that. Will target 3.x-dev, let me know if that's fine. Otherwise I'll rebase it to target 4.x-dev instead.

@sgiehl sgiehl self-assigned this Jan 23, 2020
This was referenced Jan 23, 2020
Merged
Merged
@plegault3397
Copy link
Author

plegault3397 commented Jan 23, 2020 via email

@tsteur tsteur modified the milestones: 4.1.0, 3.13.2 Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.13.2
Development

Successfully merging a pull request may close this issue.

Ensure to close visitor popover correctly matomo-org/matomo
4 participants
@tsteur @mattab @sgiehl @plegault3397