Link to 'fire an input source' algorithm, explicitly construct frame #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
commented
Aug 13, 2019
|
|
||
| 1. Let |frame| be a new {{XRFrame}} with {{XRFrame/session}} |session| for the time the event occurred. |
There was a problem hiding this comment.
It's a bit tedious to create the frame separately each time. I could also create the frame in the algorithm, however we may need to more strongly imply that the frame refers to poses from the time of the event, given that the algorithm is always called within a queued task (and thus the frame should not refer to poses from the time of the task)
There was a problem hiding this comment.
Yeah, I can see that this is a bit of a pain, but I think your logic here is sound and that this captures the intended timing well.
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #711
This ended up being a bit trickier than I thought; I can also do the very simple fix originally proposed.
r? @NellWaliczek
cc @ddorwin