Removes references to XRInputSource.gamepad from explainer and index.bs by NellWaliczek · Pull Request #782 · immersive-web/webxr · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes references to XRInputSource.gamepad from explainer and index.bs #782

Merged
merged 2 commits into from
Aug 3, 2019

Conversation

NellWaliczek
Copy link
Member

@NellWaliczek NellWaliczek commented Jul 30, 2019

This is the first of two PRs to execute the decision to split the WebXR API into separate modules. This PR handles removing the content moving to the new WebXR Gamepads Module. Removed content can be found in the partner PR in the new module repo immersive-web/webxr-gamepads-module#1

index.bs Show resolved Hide resolved
@NellWaliczek NellWaliczek marked this pull request as ready for review July 30, 2019 18:52
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential change, but otherwise this LGTM!

index.bs Outdated Show resolved Hide resolved
input-explainer.md Show resolved Hide resolved
@toji
Copy link
Member

toji commented Jul 31, 2019

Latest updates still LGTM. Thanks!

@NellWaliczek NellWaliczek merged commit c2c391a into master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants