Specify that getViewerPose throws an error for non-rAF XRFrames #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NellWaliczek
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
This is absolutely a change I've wanted to make since adding the viewerSpace. So 👍
Perhaps worth adding a sentence (maybe in the explainer?) to indicate that the pose of the viewer can still be retrieved in non-RAF frames by passing viewerSpaceinto getPose().
toji
force-pushed
the
viewer-pose-scope
branch
from
81859f7
to
659bc1d
Compare
|
Thanks! Added the recommended sentence. |
AdaRoseCannon
added
ed:spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous explainer text indicated that this scenario should have returned
null, but that seems inconsistent with the behavior of other similar restrictions, so I've updated it to throw anInvalidStateError. Thanks to Jacob DeWitt (for whom I don't yet know a GitHub handle) for helping highlight the inconsistency!