Reject promise returned from end() if session is already ended by toji · Pull Request #1170 · immersive-web/webxr · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject promise returned from end() if session is already ended #1170

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

toji
Copy link
Member

@toji toji commented Feb 5, 2021

Fixes #1166, matches implemented behavior in browsers.


Preview | Diff

@toji toji requested a review from Manishearth February 5, 2021 17:41
@Manishearth Manishearth merged commit c3878b0 into main Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider throwing an InvalidStateError if ended is already true in XRSession end()
2 participants