Clarify that minimum viewport scale may change #1134
Conversation
The minimum viewport scale must ensure that the viewport has a nonzero size, and this may in theory require an adjustment if the session's baseLayer is changed during a session to use a very small framebufferScaleFactor. Change the wording to clarify that it's not necessarily constant for an entire session.
|
On second thought, I think it would be easier to enforce the nonzero size
in getViewport, then this change isn't needed and there's less ambiguity
about baseLayer changes.
…On Tue, Sep 29, 2020, 15:59 Klaus Weidner ***@***.***> wrote:
The minimum viewport scale must ensure that the viewport has a nonzero
size, and this may in theory require an adjustment if the session's
baseLayer is changed during a session to use a very small
framebufferScaleFactor.
Change the wording to clarify that it's not necessarily constant for an
entire session.
------------------------------
You can view, comment on, or merge this pull request online at:
#1134
Commit Summary
- Clarify that minimum viewport scale may change
File Changes
- *M* index.bs
<https://github.com/immersive-web/webxr/pull/1134/files#diff-ec9cfa5f3f35ec1f84feb2e59686c34d>
(2)
Patch Links:
- https://github.com/immersive-web/webxr/pull/1134.patch
- https://github.com/immersive-web/webxr/pull/1134.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1134>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKT5XYAR5TRQWXX6SH22FTSIJRD7ANCNFSM4R6MHFDA>
.
|
Yes, you can update |
Add the nonzero viewport size and optional UA minimum viewport scale constraints to the getViewport algorithm instead.
I've moved the logic there.
I'm not aware of a specific UA requirement (beyond ensuring nonzero size), but I added an optional adjustment there where the UA could clamp to a minimum viewport scale. |
The minimum viewport scale must ensure that the viewport has a nonzero
size, and this may in theory require an adjustment if the session's
baseLayer is changed during a session to use a very small
framebufferScaleFactor.
Change the wording to clarify that it's not necessarily constant for an
entire session.
Preview | Diff