Editorial: Align with Web IDL specification by autokagami · Pull Request #1116 · immersive-web/webxr · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Align with Web IDL specification #1116

Closed
wants to merge 1 commit into from
Closed

Editorial: Align with Web IDL specification #1116

wants to merge 1 commit into from

Conversation

autokagami
Copy link
Contributor

@autokagami autokagami commented Aug 18, 2020 •
edited by pr-preview bot
Loading

This is an automated pull request to align the spec with the latest Web IDL specification.

Currently the autofix might introduce some awkward code formatting, so please feel free to modify the formatting.

Please file an issue on https://github.com/saschanaz/webidl-updater/issues/new if you think this PR is invalid or should be enhanced.

The following is the validation messages from webidl2.js, which may help understanding this PR:

Validation error at line 14 in webxr,4:
  void updateRenderState(optional XRRenderStateInit
  ^ `void` is now replaced by `undefined`. Refer to the [relevant GitHub issue](https://github.com/heycam/webidl/issues/60) for more information.

Validation error at line 18 in webxr,4:
  void cancelAnimationFrame(unsigned long
  ^ `void` is now replaced by `undefined`. Refer to the [relevant GitHub issue](https://github.com/heycam/webidl/issues/60) for more information.

Validation error at line 20 in webxr,4:
  Promise<void> end()
          ^ `void` is now replaced by `undefined`. Refer to the [relevant GitHub issue](https://github.com/heycam/webidl/issues/60) for more information.

Validation error at line 1 in webxr,6:
callback XRFrameRequestCallback = void (DOMHighResTimeStamp time,
                                  ^ `void` is now replaced by `undefined`. Refer to the [relevant GitHub issue](https://github.com/heycam/webidl/issues/60) for more information.

Validation error at line 6 in webxr,20:
    [NewObject] Promise<void> makeXRCompatible()
                        ^ `void` is now replaced by `undefined`. Refer to the [relevant GitHub issue](https://github.com/heycam/webidl/issues/60) for more information.

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Aug 18, 2020, 4:34 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

This was referenced Aug 18, 2020
Closed
Closed
@toji
Copy link
Member

toji commented Aug 18, 2020

Something is strange about the diff for this PR, as it seems to include a lot of changes that already exist in top-of-tree and appears to be diffing against a much older version of the spec. The change in question is relatively simple, though, so I've posted #1117 to do the same thing.

@toji toji closed this Aug 18, 2020
@toji toji mentioned this pull request Sep 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@autokagami @toji