Explicitly specify that reset events work on offset spaces by Manishearth · Pull Request #1024 · immersive-web/webxr · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly specify that reset events work on offset spaces #1024

Merged
merged 1 commit into from
May 11, 2020
Merged

Explicitly specify that reset events work on offset spaces #1024

merged 1 commit into from
May 11, 2020

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth commented May 11, 2020 •
edited by pr-preview bot
Loading

I considered writing this out as steps, but I realized the reset event really has one step and all the complexity is in the conditions when it gets triggered.

Fixes #933

Preview | Diff

@Manishearth Manishearth requested a review from toji May 11, 2020 20:56
toji
toji approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@toji toji merged commit fd033e5 into immersive-web:master May 11, 2020
@Manishearth Manishearth deleted the reset-offset branch May 11, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toji toji toji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify that offset spaces inherit reset events and bounds changes
2 participants
@Manishearth @toji