pprof: support limit the max number for dumping goroutines. by doujiang24 · Pull Request #50771 · golang/go · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pprof: support limit the max number for dumping goroutines. #50771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pprof: support limit the max number for dumping goroutines. #50771

wants to merge 1 commit into from
+46 −10

Conversation

doujiang24
Copy link
Contributor

pprof may take too much time when there are many goroutines.
The new SetMaxDumpGoroutineNum API set the max goroutine number for dumping.

@doujiang24
pprof: support limit the max number for dumping goroutines.
554647c 
pprof may take too much time when there are huge goroutines.
The new SetMaxDumpGoroutineNum API set the max goroutine number for dumping.
@doujiang24
Copy link
Contributor Author

Now, the SetMaxDumpGoroutineNum API introduced a new global variable.
This may not be a good idea, but I don't know the better way.

@gopherbot
Copy link
Contributor

This PR (HEAD: 554647c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/380454 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Austin Clements:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/380454.
After addressing review feedback, remember to publish your drafts!

@doujiang24 doujiang24 mentioned this pull request Jan 25, 2022
Closed
@gopherbot
Copy link
Contributor

Message from DeJiang Zhu:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/380454.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doujiang24 @gopherbot