-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Degree Filter Not Filtering as Subfilter in Tookit #69
Comments
(by emeeks-stanford) |
(by emeeks-stanford) |
(by mathieu.bastian) I fixed something in the Range class and did some tests on a random graph. Can you please pull the trunk, build the new toolkit and test? In addition I fixed another bug so you don't have to call init() on your filters anymore. That should be done by the system, but it was throwing an exception without. Moreover, you can now execute a layout with N iterations directly from the layout controller: |
(by emeeks-stanford) |
Ok. The reason was because the original graph had a minimum degree at 1. By setting the filter [1, +inf] the system was auto adapting the minimum bound from 1 to 0 because it understood you want the minimum. This is a case I didn't think at all when designed the system. At the end adapting the bounds is not something desirable for the toolkit but it requires to change quite a lot of things. Finally I changed some things to init the ranges only when FilterController.add() is called and not createQuery(). That should solves the problem as the range will not adapt because it doesn't know the previous value (because init was not called). |
I've nested a Partition filter in a Degree filter and it doesn't filter out the Degree 0 values. It does seem to work if the minimum degree value is set to 2. The attached gexf and main script are what I'm using.
Imported from Launchpad using lp2gh.
The text was updated successfully, but these errors were encountered: