codegen: Plug leak in server-side GDBus reply handling · frida/vala@d07b689 · GitHub
Skip to content

Commit

Permalink
codegen: Plug leak in server-side GDBus reply handling
Browse files Browse the repository at this point in the history
Introduced by me when optimizing the reply handling in 74a66f9.

Kudos to @rev1si0n for reporting and helping track this one down.
  • Loading branch information
oleavr committed Jun 17, 2022
1 parent e29e312 commit d07b689
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions codegen/valagdbusservermodule.vala
Original file line number Diff line number Diff line change
@@ -480,6 +480,10 @@ public class Vala.GDBusServerModule : GDBusClientModule {

if (ready_data_expr != null && !ready) {
ccode.open_if (new CCodeIdentifier ("_fire_and_forget"));

var unref_call = new CCodeFunctionCall (new CCodeIdentifier ("g_object_unref"));
unref_call.add_argument (new CCodeMemberAccess.pointer (ready_data_expr, "_invocation_"));
ccode.add_expression (unref_call);
}

foreach (Parameter param in m.get_parameters ()) {

0 comments on commit d07b689

Please sign in to comment.