-
Notifications
You must be signed in to change notification settings - Fork 28.4k
CupertinoPicker fidelity revision #31464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xster
added a commit
to xster/goldens
that referenced
this pull request
Apr 23, 2019
xster
added a commit
to flutter/goldens
that referenced
this pull request
Apr 24, 2019
Sorry for the spammy commits. Ready for a look now. |
LongCatIsLooong
approved these changes
Apr 24, 2019
dnfield
added a commit
to flutter/goldens
that referenced
this pull request
Apr 24, 2019
This reverts commit 651e319.
dnfield
added a commit
to flutter/goldens
that referenced
this pull request
Apr 24, 2019
This reverts commit 651e319.
xster
added a commit
to xster/goldens
that referenced
this pull request
Apr 25, 2019
xster
added a commit
to flutter/goldens
that referenced
this pull request
Apr 25, 2019
…hange the size without positioning it somewhere
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a: fidelity
Matching the OEM platforms better
f: cupertino
flutter/packages/flutter/cupertino repository
f: date/time picker
Date or time picker widgets
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revised the cupertino picker and date time picker
Before:

After:


Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?