CupertinoPicker fidelity revision by xster · Pull Request #31464 · flutter/flutter · GitHub
Skip to content

CupertinoPicker fidelity revision #31464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 25, 2019
Merged

CupertinoPicker fidelity revision #31464

merged 11 commits into from
Apr 25, 2019

Conversation

xster
Copy link
Member

@xster xster commented Apr 23, 2019

Description

Revised the cupertino picker and date time picker

  • Add a new squeeze argument to RenderListWheelViewport to customize angular density on the cylinder
  • Add text theming support to pickers
  • Add today label for date time picker
  • Small tweaks on various picker/date time picker parameters
  • Add a check to make sure enough horizontal space is available to show the picker

Before:
Screen Shot 2019-04-22 at 5 23 37 PM

After:
Screen Shot 2019-04-22 at 6 58 59 PM
Screen Shot 2019-04-22 at 6 16 27 PM

Tests

I added the following tests:

  • squeeze test in list_wheel_scroll_view_test
  • font test in picker_test

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@xster xster requested a review from LongCatIsLooong April 23, 2019 02:26
@xster xster added a: fidelity Matching the OEM platforms better f: cupertino flutter/packages/flutter/cupertino repository f: date/time picker Date or time picker widgets framework flutter/packages/flutter repository. See also f: labels. labels Apr 23, 2019
xster added a commit to xster/goldens that referenced this pull request Apr 23, 2019
xster added a commit to flutter/goldens that referenced this pull request Apr 24, 2019
@xster
Copy link
Member Author

xster commented Apr 24, 2019

Sorry for the spammy commits. Ready for a look now.

dnfield added a commit to flutter/goldens that referenced this pull request Apr 24, 2019
dnfield added a commit to flutter/goldens that referenced this pull request Apr 24, 2019
xster added a commit to xster/goldens that referenced this pull request Apr 25, 2019
xster added a commit to flutter/goldens that referenced this pull request Apr 25, 2019
@xster xster force-pushed the picker-fidelity branch from c3fb44d to bd03cfd Compare April 25, 2019 00:39
@xster xster merged commit 8cfc924 into flutter:master Apr 25, 2019
@xster xster deleted the picker-fidelity branch April 25, 2019 07:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: fidelity Matching the OEM platforms better f: cupertino flutter/packages/flutter/cupertino repository f: date/time picker Date or time picker widgets framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants