change: Migrate credentials to use google-auth-library by lahirumaramba · Pull Request #2466 · firebase/firebase-admin-node · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: Migrate credentials to use google-auth-library #2466

Merged
merged 10 commits into from
Nov 4, 2024
Merged

change: Migrate credentials to use google-auth-library #2466

merged 10 commits into from
Nov 4, 2024

Conversation

lahirumaramba
Copy link
Member

@lahirumaramba lahirumaramba commented Feb 21, 2024 •
edited
Loading

  • Migrate Application default credentials, Service account credentials, Refresh token credentials, and Compute engine credentials to use google-auth-library

Resolves: #1377

This was referenced Feb 28, 2024
Open
Open
jonathanedey
jonathanedey reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Left one comment.

src/app/credential-internal.ts
);
return {
...credentials,
access_token: accessToken,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to assign access_token here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I am keeping the shape of the internal GoogleOAuthAccessToken type here

@lahirumaramba lahirumaramba self-assigned this Feb 29, 2024
@andrewmbenton andrewmbenton mentioned this pull request Mar 19, 2024
Closed
@foxrafa
Copy link
Contributor

foxrafa commented May 13, 2024

I submitted a fix for ADC not working for human accounts here #2553

@jenh jenh mentioned this pull request May 28, 2024
Merged
@lahirumaramba lahirumaramba mentioned this pull request Jun 18, 2024
Merged
@VitaliAndrushkevich
Copy link

Could you please provide an update on the status of this PR?
CC: @lahirumaramba

@KemingHe
Copy link

KemingHe commented Jul 7, 2024

@lahirumaramba @hsubox76 Hello there, as a firebase admin sdk user, I much look forward to this PR getting through, could you please give us a status update? Thank you.

@swftvsn swftvsn mentioned this pull request Aug 6, 2024
Closed
@lahirumaramba lahirumaramba mentioned this pull request Sep 12, 2024
Closed
@lahirumaramba lahirumaramba marked this pull request as ready for review November 1, 2024 22:01
@lahirumaramba lahirumaramba marked this pull request as draft November 1, 2024 22:01
@lahirumaramba lahirumaramba marked this pull request as ready for review November 1, 2024 22:02
@lahirumaramba lahirumaramba marked this pull request as draft November 1, 2024 22:02
@lahirumaramba lahirumaramba marked this pull request as ready for review November 1, 2024 22:02
@lahirumaramba lahirumaramba changed the title feat: Migrate credentials to use google-auth-library change: Migrate credentials to use google-auth-library Nov 3, 2024
@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label Nov 3, 2024
@lahirumaramba lahirumaramba merged commit 2144b12 into master Nov 4, 2024
10 checks passed
@lahirumaramba lahirumaramba deleted the lm-migrate-cred-stage1 branch November 4, 2024 20:12
This was referenced Nov 5, 2024
Closed
Merged
@ivstiv ivstiv mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanedey jonathanedey jonathanedey left review comments

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels
release:stage Stage a release candidate release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Allow credential file type "external_account" when calling admin.credential.applicationDefault()
6 participants
@lahirumaramba @foxrafa @VitaliAndrushkevich @KemingHe @hsubox76 @jonathanedey