You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running the migration on a war file that contains an exploded osgi bundle the class files and jar files within the exploded bundle are migrated but the manifest file is not.
An example of the war archive layout with an exploded osgi bundle could be
For bundles that are not exploded, the manifest along with classes and jar files inside the bundle are all migrated
WEB-INF/
WEB-INF/bundles/
WEB-INF/bundles/com.example.service.jar <--- everything is migrated
From looking at the code of the class org.apache.tomcat.jakartaee.ManifestConverter the issue appears to be that the check for migrating a manifest will only work when the manifest file is at the root of an archive because it expects to find the parent folder name in the entry name, e.g. "META-INF/MANIFEST.MF", but when running on an exploded artifact then the file name for the entry will be a path inside the parent archive, e.g. "WEB-INF/bundles/com.example.service/META-INF/MANIFEST.MF" from the example above.
The text was updated successfully, but these errors were encountered:
Hi,
When running the migration on a war file that contains an exploded osgi bundle the class files and jar files within the exploded bundle are migrated but the manifest file is not.
An example of the war archive layout with an exploded osgi bundle could be
WEB-INF/
WEB-INF/bundles/
WEB-INF/bundles/com.example.service/
WEB-INF/bundles/com.example.service/META-INF/
WEB-INF/bundles/com.example.service/META-INF/MANIFEST.MF <--- not migrated
WEB-INF/bundles/com.example.service/lib/
WEB-INF/bundles/com.example.service/lib/com.example.code.jar <--- migrated
For bundles that are not exploded, the manifest along with classes and jar files inside the bundle are all migrated
WEB-INF/
WEB-INF/bundles/
WEB-INF/bundles/com.example.service.jar <--- everything is migrated
From looking at the code of the class org.apache.tomcat.jakartaee.ManifestConverter the issue appears to be that the check for migrating a manifest will only work when the manifest file is at the root of an archive because it expects to find the parent folder name in the entry name, e.g. "META-INF/MANIFEST.MF", but when running on an exploded artifact then the file name for the entry will be a path inside the parent archive, e.g. "WEB-INF/bundles/com.example.service/META-INF/MANIFEST.MF" from the example above.
The text was updated successfully, but these errors were encountered: