Fix BZ 65203 Correct regression in previous release. · apache/tomcat@b59099e · GitHub
Skip to content

Commit

Permalink
Fix BZ 65203 Correct regression in previous release.
Browse files Browse the repository at this point in the history
Failure to recycle the newly added errorException object meant once an
error occurred on an aysnc read, all subsequent async reads would fail.

https://bz.apache.org/bugzilla/show_bug.cgi?id=65203
  • Loading branch information
markt-asf committed Mar 24, 2021
1 parent 4f23408 commit b59099e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions java/org/apache/coyote/Request.java
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,8 @@ public void recycle() {
authType.recycle();
attributes.clear();

errorException = null;

listener = null;
synchronized (nonBlockingStateLock) {
fireListener = false;
Expand Down
5 changes: 5 additions & 0 deletions webapps/docs/changelog.xml
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
received for completed streams else the flow control window may become
exhausted. (markt)
</fix>
<fix>
<bug>65203</bug>: Fix a regression introduced in 10.0.4 that meant that
an error during an asynchronous read broke all future asynchronous reads
associated with the same request instance. (markt)
</fix>
</changelog>
</subsection>
<subsection name="Jasper">
Expand Down

0 comments on commit b59099e

Please sign in to comment.