Fix CVE-2022-34305 XSS in the examples web application

The session attributes are the primary concern but filter the Principal attributes as well to be on the safe side.
apache · Jun 23, 2022 · 1a7e95d · 1a7e95d
1 parent 8dfe1b4
commit 1a7e95d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
@@ -151,6 +151,10 @@
         Documentation. <bug>62245</bug>: Include <code>contextXsltFile</code>
         when discussing options for configuring directory listings. (markt)
       </fix>
+      <fix>
+        Examples. Fix CVE-2022-34305, a low severity XSS vulnerability in the
+        Form authentication example. (markt)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Other">

diff --git a/webapps/examples/jsp/security/protected/index.jsp b/webapps/examples/jsp/security/protected/index.jsp
@@ -107,7 +107,11 @@ enter it here:
       }
       type = type.replaceFirst("^java\\.lang\\.", "");
 %>
-<tr><td><%= name %></td><td><%= value %></td><td><%= type %></td>
+<tr>
+  <td><%= util.HTMLFilter.filter(name) %></td>
+  <td><%= util.HTMLFilter.filter(String.valueOf(value)) %></td>
+  <td><%= util.HTMLFilter.filter(type) %></td>
+</tr>
 <%
     }
 %>
@@ -139,7 +143,10 @@ To add some data to the authenticated session, enter it here:
   while (names.hasMoreElements()) {
     String name = names.nextElement();
 %>
-<tr><td><%= name %></td><td><%= session.getAttribute(name) %></td>
+<tr>
+  <td><%= util.HTMLFilter.filter(name) %></td>
+  <td><%= util.HTMLFilter.filter(String.valueOf(session.getAttribute(name))) %></td>
+</tr>
 <%
   }
 %>