[Fix][UI] Fix the message toast issue by rockfang · Pull Request #16088 · apache/dolphinscheduler · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI] Fix the message toast issue #16088

Merged
merged 2 commits into from
May 30, 2024
Merged

[Fix][UI] Fix the message toast issue #16088

merged 2 commits into from
May 30, 2024

Conversation

rockfang
Copy link
Contributor

Purpose of the pull request

to fix #16087

Brief change log

To enhance the robustness of the code when showing messages in the data source connection and testing message sending

Verify this pull request

image
image

@github-actions github-actions bot added the UI ui and front end related label May 29, 2024
@SbloodyS SbloodyS added bug Something isn't working 3.3.0 labels May 29, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone May 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.68%. Comparing base (ac1eaca) to head (eccf1e2).

Current head eccf1e2 differs from pull request most recent head 234ccc4

Please upload reports for the commit 234ccc4 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16088      +/-   ##
============================================
+ Coverage     40.67%   40.68%   +0.01%     
- Complexity     5238     5239       +1     
============================================
  Files          1382     1382              
  Lines         46023    46023              
  Branches       4922     4922              
============================================
+ Hits          18719    18724       +5     
+ Misses        25379    25374       -5     
  Partials       1925     1925              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@SbloodyS SbloodyS merged commit d8e0178 into apache:dev May 30, 2024
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3.0 bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [UI] Success message toast not works well
6 participants