[Improvement][Flink] Change Flink command into FLINK_HOME by pegasas · Pull Request #16004 · apache/dolphinscheduler · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][Flink] Change Flink command into FLINK_HOME #16004

Merged
merged 1 commit into from
May 29, 2024
Merged

[Improvement][Flink] Change Flink command into FLINK_HOME #16004

merged 1 commit into from
May 29, 2024

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented May 15, 2024

Purpose of the pull request

fix: #16003

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Radeity
Radeity previously approved these changes May 15, 2024
View reviewed changes
@Radeity
Copy link
Member

Radeity commented May 15, 2024

Hi @pegasas, please fix UT.

@pegasas
Copy link
Contributor Author

pegasas commented May 15, 2024

Hi @pegasas, please fix UT.

Thanks, Done.
image

ruanwenjun
ruanwenjun previously approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label May 15, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone May 15, 2024
Radeity
Radeity previously approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Radeity
Copy link
Member

Radeity commented May 15, 2024

Please run mvn spotless:apply @pegasas

@pegasas pegasas dismissed stale reviews from Radeity and ruanwenjun via 162950b May 15, 2024 13:44
@pegasas
Copy link
Contributor Author

pegasas commented May 15, 2024

Please run mvn spotless:apply @pegasas

Weired,
it seems my change has not been posted.
Thanks
image

SbloodyS
SbloodyS reviewed May 16, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix UT. @pegasas

rickchengx
rickchengx previously approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@rickchengx rickchengx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the UT

@pegasas
Copy link
Contributor Author

pegasas commented May 16, 2024

LGTM, please fix the UT

image
image

Sorry I missed test in flink-stream.
Done and pass spotless check on my local machine.

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.66%. Comparing base (ec01df1) to head (b1f938d).
Report is 1 commits behind head on dev.

❗ Current head b1f938d differs from pull request most recent head 081f834

Please upload reports for the commit 081f834 to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #16004      +/-   ##
============================================
- Coverage     40.67%   40.66%   -0.01%     
+ Complexity     5238     5237       -1     
============================================
  Files          1382     1382              
  Lines         46023    46023              
  Branches       4922     4922              
============================================
- Hits          18719    18716       -3     
- Misses        25379    25381       +2     
- Partials       1925     1926       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun removed the 3.2.2 label May 29, 2024
@ruanwenjun ruanwenjun modified the milestones: 3.2.2, 3.3.0 May 29, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ruanwenjun
ruanwenjun approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun added ready-to-merge minor Chore Chores about the project, like code clean, typo, etc. labels May 29, 2024
rickchengx
rickchengx approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx rickchengx merged commit a724518 into apache:dev May 29, 2024
63 checks passed
@pegasas pegasas deleted the issues/16003 branch May 29, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS left review comments

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@rickchengx rickchengx rickchengx approved these changes

@Radeity Radeity Radeity left review comments

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

Assignees

@pegasas pegasas

Labels
3.3.0 backend improvement make more easy to user or prompt friendly minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

[Improvement][Flink] Change Flink command into FLINK_HOME
6 participants
@pegasas @Radeity @codecov-commenter @SbloodyS @ruanwenjun @rickchengx