fix(sharable): agreementData preview screen on shared generated-link bug fixed #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Vinyl-Davyl
changed the title
Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
Vinyl-Davyl
force-pushed
the
vinyl/fix/preview-in-sharable
branch
from
9b4fd34 to
616c688
Compare
mttrbrts
approved these changes
Jul 30, 2024
nitro56565
pushed a commit
to nitro56565/template-playground
that referenced
this pull request
Aug 2, 2024
…bug fixed (accordproject#90) * fix: agreementHtml preview screen on generated link bug fixed Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com> * test(update): updated recurring test case Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com> --------- Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com> Signed-off-by: Mahesh Patil <nitro56565@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
agreementHtmlwas not showing the preview on the shared generated link.agreementHtmlis included in the state when generating the shareable link.Flags
rebuildfunction to ensureagreementHtmlis correctly set for testing.Screenshots or Video
Author Checklist
--signoffoption of git commit.mainfromfork:branchname