chore(refactor): enhanced general project structure by Vinyl-Davyl · Pull Request #88 · accordproject/template-playground · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): enhanced general project structure #88

Merged
merged 8 commits into from
Jul 27, 2024

Conversation

Vinyl-Davyl
Copy link
Collaborator

Changes

  • refactor: streamlined and reorganized folder structure and organization aide maintainability and clarity.

Flags

  • Ensure all import paths have been updated to reflect the new folder structure.
  • Review project documentation to verify references to the renamed folders.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@Vinyl-Davyl Vinyl-Davyl requested a review from a team as a code owner July 25, 2024 22:17
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 9e67fbd
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/66a5124c091a370008e5cb45
😎 Deploy Preview https://deploy-preview-88--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Vinyl-Davyl Vinyl-Davyl force-pushed the vinyl/folder-structure branch from 24fb131 to 28385a2 Compare July 25, 2024 22:19
@Vinyl-Davyl Vinyl-Davyl changed the title chore(refactor): enhanced project structure chore(refactor): enhanced general project structure Jul 25, 2024
Copy link
Member

@sanketshevkar sanketshevkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just a small suggestion, utils can be a part of src itself. I don't think we are using it anywhere outside of the src folder.

@Vinyl-Davyl Vinyl-Davyl force-pushed the vinyl/folder-structure branch from a5d24a4 to 412bf0b Compare July 26, 2024 10:16
@Vinyl-Davyl
Copy link
Collaborator Author

This looks good. Just a small suggestion, utils can be a part of src itself. I don't think we are using it anywhere outside of the src folder.

True, Resolved!

@Vinyl-Davyl Vinyl-Davyl force-pushed the vinyl/folder-structure branch from e573d2f to 41a8f03 Compare July 26, 2024 10:26
tsconfig.json Outdated Show resolved Hide resolved
Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
@Vinyl-Davyl Vinyl-Davyl force-pushed the vinyl/folder-structure branch from 849fdaf to 9e67fbd Compare July 27, 2024 15:29
@sanketshevkar sanketshevkar merged commit 101fabd into accordproject:main Jul 27, 2024
7 checks passed
Vinyl-Davyl added a commit to Vinyl-Davyl/template-playground that referenced this pull request Jul 29, 2024
* update: store into stores folder

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* update(editors): development

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* update: development

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* update: development

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* update: development

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* chore: utils >>> src

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* chore: dev fixes

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* fix: reslove issues

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

---------

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
mttrbrts pushed a commit that referenced this pull request Jul 29, 2024
* test: compression tests

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* chore(refactor): enhanced general project structure (#88)

* update: store into stores folder

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* update(editors): development

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* update: development

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* update: development

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* update: development

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* chore: utils >>> src

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* chore: dev fixes

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* fix: reslove issues

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

---------

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* test: generate sharable link test

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

* update: development

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

---------

Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants