Social Icons: add Gravatar service #56544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new Social Link icon, for the Gravatar service. Gravatar is used in other places within WordPress, and offers profile pages that one can use to list their presence on the web. It can be useful to link to that from your blog.
t-hamano
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Thanks for the PR!
Since Gravatar is closely associated with WordPress users, and the Gravatar page allows you to customize a lot of information about your profile, I think it makes sense to add this service.
It's totally fine in the codebase, but I'd like to ping @richtabor @jameskoster @jasmussen for design feedback.
t-hamano
added
Needs Design Feedback
|
Seems reasonable to me. |
apeatling
approved these changes
Nov 29, 2023
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
This introduces a new Social Link icon, for the Gravatar service. Gravatar is used in other places within WordPress, and offers profile pages that one can use to list their presence on the web. It can be useful to link to that from your blog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This introduces a new Social Link icon, for the Gravatar service.
Why?
Gravatar is used in other places within WordPress, and offers profile pages that one can use to list their presence on the web. It can be useful to link to that from your blog.
How?
This adds the new icon and service, as well as tests.
Testing Instructions
Testing Instructions for Keyboard
Same as above, this behavior does not change in this PR.
Screenshots or screencast
Editor
Frontend, when a label is added for the icon