-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(A1) path traversel lesson 7 seems broken #1103
Comments
Thanks for submitting your first issue, we will have a look as quickly as possible. |
It seems there are indeed some issues. One of these is that you are required to have passed lesson 2 before lesson 7. |
I can have a look, I have a branch were I started to write up the solution. |
I experience the same issue with webgoat-8.2.2
I don't think it is. That file is not in the profile directory (~/.webgoat-8.2.2) but part of the webserver. I have found this seemingly-related function which weirdly enough doesn't seem to get called at all: webgoat.customjs.profileZipSlipRetrieval = function () {
$.get("PathTraversal/zip-slip", function (result, status) {
document.getElementById("previewZipSlip").src = "data:image/png;base64," + result;
});
} The question remains - where should the uploaded picture go to ? The challenge is marked as finished sending any zip file. Page 8 of the lesson shows that the solution is about overwriting:
but uploading that didn't work for me and the profile picture remained the same. Also the java fix code shown in the solution seems abrupt: File profilePicture = new File(uploadDirectory, e.getName());
if (profilePicture. |
That is related to the reuse of the same directory. The Zip Slip lesson now cleans the directory before processing the upload of the zipfile. |
Closing as we released 2023.3 |
The zip slip assignment appears to be broken.
The goal is to somehow override
/WebGoat/images/account.png
when looking at the requests.The current location where the zip is extracted is
/home/webgoat/.webgoat-8.2.1/PathTraversal/<NAME>/<INJECT_ME/FILENAME>.png
Uploading a zip with just containing an image, e.g.,
hack.png
, marks the lesson as completed.However, the info message is
Zip file extracted successfully, failed to copy image. Please contact our helpdesk.
It is also unclear from inspecting the Docker container where the image should be put. The source seems to always call
getProfilePicture
, which fetches it fromthis.webGoatHomeDirectory, "/PathTraversal/" + webSession.getUserName()
, which is where the image is already extracted?The text was updated successfully, but these errors were encountered: