Add annotation based support for HyperSchema to JsonSchema · Issue #35 · FasterXML/jackson-module-jsonSchema · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation based support for HyperSchema to JsonSchema #35

Closed
mavarazy opened this issue Apr 21, 2014 · 9 comments
Closed

Add annotation based support for HyperSchema to JsonSchema #35

mavarazy opened this issue Apr 21, 2014 · 9 comments
Milestone

Comments

@mavarazy
Copy link
Contributor

http://stackoverflow.com/questions/23192297/how-to-use-jackson-hyperschema-to-generate-schema-link-references

@cowtowncoder
Copy link
Member

I do not yet see the matching pull request here? Thank you in advance for the contribution -- this sounds like a good addition. I will go over the changes when I have time.

One thing we will need to merge the contribution is to get a filled Contributor License Agreement. You can find a copy of it under 'DEV/contributor-agreement.pdf' of this project.
A common way to fill it is to print, sign, scan, and then email to "info" at "fasterxml.com".
Only one CLA is needed by single contributor and it covers all FasterXML Jackson projects. So it is a one-time only thing to ensure that project can use and distribute all code, patches and so on.

@cowtowncoder
Copy link
Member

Ah ok. I actually do see the PR now (browser had a cached copy or something): #36.

So, we just need the CLA; and I will try to get patch itself reviewed.

@mavarazy
Copy link
Contributor Author

I've updated a pull request

@cowtowncoder
Copy link
Member

Hi @mavarazy! I think this patch looks good, so I would like to merge it. But before I do that, we need a filled Contributor License Agreement (CLA), as per my earlier note. Would it be possible to get that? I apologize for the hassle, but it only needs to be done once.

@mavarazy
Copy link
Contributor Author

Never mind, found it :) Send it :)

@mavarazy
Copy link
Contributor Author

Sent it

@cowtowncoder
Copy link
Member

@mavarazy Thank you! Also once again, thank you for all your contributions so far, these are very useful and we want to work hard to get them in to help others.

cowtowncoder added a commit that referenced this issue Jun 17, 2014
@mavarazy
Copy link
Contributor Author

Great, Thanks :) You can send me issues for this feature :)

@cowtowncoder
Copy link
Member

Perfect. This will go in 2.4.1 (as sort of exception to usual 'no new features'; we can consider this "early access" or sneak-peek feature).

@cowtowncoder cowtowncoder added this to the 2.2.3 milestone Jun 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants