Add tests for MetricsUpdateTask and squash some bugs along the way
#1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DependencyTrack#1525 Signed-off-by: nscuro <nscuro@protonmail.com>
* The count of audited and suppressed findings was off, as their queries still included `project == null` expressions. Probably leftovers from the global component model before v4. * The count of audited findings was off, because it didn't account for suppressed findings. If a finding is suppressed, the overall finding count is reduced as well. Until now however, suppressed findings were considered "audited" as well, which could result in situations where more findings are audited than even exist. * The audited/unaudited counts of policy violations were off, because the count of audited violations was never populated. * Suppressed policy violations were not reflected in the metrics. Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro
changed the title
MetricsUpdateTask and squash some bug along the wayMetricsUpdateTask and squash some bugs along the way
|
Note that some of these bugs were not visible in the dashboard, and in consequence neither to most users. For example, the wrong suppression count for component metrics did not lead to overall wrong suppression counts, because suppressions are queried again on the project level. So the sum on the dashboard would still be accurate, but for component metrics fetched via the API, it wasn't. Also, per-type audited/unaudited counts of policy violations aren't displayed anywhere in the UI yet. |
|
Huge thanks for the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for
MetricsUpdateTask, making it easier to debug and verify its functionality when stuff gets changed.project == nullexpressions. Probably leftovers from the global component model before v4.This PR also includes #1526.