Further stabilization of extensions in beacon mode by DominicBreuker · Pull Request #1164 · BishopFox/sliver · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further stabilization of extensions in beacon mode #1164

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Further stabilization of extensions in beacon mode #1164

merged 4 commits into from
Mar 23, 2023

Conversation

DominicBreuker
Copy link
Contributor

Card

Beacons still crash when some extensions are called or are called too often within a single beacon check in. This code does two things:

  • ensure all beacon registration tasks are executed before any other task gets executed, to prevent calling an extension that has not been registered yet
  • ensure the wait group counter for beacon task execution cannot become negative, which could and does cause panics (c.f. BOF execution instability #679)

Details

@DominicBreuker DominicBreuker requested a review from a team as a code owner March 23, 2023 21:00
@rkervella
Copy link
Member

rkervella commented Mar 23, 2023 •
edited
Loading

Fixes #679 and #1121

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-scanning.yml:CodeQL-Build. As part of the setup process, we have scanned this repository and found 20 existing alerts. Please check the repository Security tab to see all alerts.

@rkervella rkervella merged commit 749f71d into BishopFox:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkervella rkervella rkervella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominicBreuker @rkervella