Add label/link to log in with email view to manually log in. by roundhill · Pull Request #3256 · Automattic/simplenote-electron · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label/link to log in with email view to manually log in. #3256

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Add label/link to log in with email view to manually log in. #3256

merged 4 commits into from
Sep 13, 2024

Conversation

roundhill
Copy link
Contributor

@roundhill roundhill commented Sep 9, 2024 •
edited
Loading

Fix #3255

Adds a label with a link on the email log in form so that you can get to the password entry if desired.

I've also removed the isDev check for showing password entry for dev mode - since you can click the link now to sign in with password that should work ok for devs to sign in.

Screenshot 2024-09-09 at 3 54 28 PM

Test

  1. Sign out.
  2. npm run dev
  3. You should see email log in form, click the new manually log in link.
  4. You should now be at the password log in form.
  5. Try click back to email log in, sign up, etc. You should only see the new label when on the email log in form.
  6. Signing in should work (best to download a build of this PR so magic links work)

codebykat
codebykat approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, and I like this better (especially not special-casing things for dev mode). 👍

@roundhill roundhill changed the base branch from trunk to release/2.22.2 September 12, 2024 22:38
@mokagio
Copy link
Contributor

mokagio commented Sep 12, 2024

Looking good!

The Windows build failed, but the error looks like connectivity rather than our code

npm ERR! code EIDLETIMEOUT
npm ERR! Idle timeout reached for host `registry.npmjs.org:443`

I re-tried that job. Ready to merge if green 👍

@codebykat codebykat merged commit ad67fd7 into release/2.22.2 Sep 13, 2024
7 checks passed
@codebykat codebykat deleted the roundhill/3255-manual-login-link branch September 13, 2024 00:16
@codebykat codebykat mentioned this pull request Sep 13, 2024
Closed
@codebykat codebykat mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebykat codebykat codebykat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add magic link label with an option to sign in with password
3 participants
@roundhill @mokagio @codebykat