Update: Disable sticky scroll option by codebykat · Pull Request #3254 · Automattic/simplenote-electron · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Disable sticky scroll option #3254

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

codebykat
Copy link
Member

@codebykat codebykat commented Sep 5, 2024

Fix

Potential fix for #3250. Also removes this, and some unused features, from the package.

This is a hotfix for 2.22.2 release.

(I updated the list of possible features by importing metadata and logging it to console, as recommended in the linked README.)

Release

Disabled "sticky scrolling" option (#3254)

@codebykat codebykat self-assigned this Sep 5, 2024
@codebykat codebykat changed the base branch from trunk to release/2.22.2 September 5, 2024 19:16
@codebykat codebykat marked this pull request as ready for review September 5, 2024 19:22
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Too bad we can't reproduce but we can circle back with the user to see if it fixed it for them.

@codebykat codebykat merged commit 7ecb7c8 into release/2.22.2 Sep 6, 2024
7 checks passed
@codebykat codebykat deleted the update/stickyscroll branch September 6, 2024 17:16
@mokagio
Copy link
Contributor

mokagio commented Sep 12, 2024

@roundhill @codebykat

Looks good! Too bad we can't reproduce but we can circle back with the user to see if it fixed it for them.

A new build with this change is now available https://github.com/Automattic/simplenote-electron/releases/tag/v2.22.2-beta.5 if we want to followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants