Remove `gconf2` dependency by mokagio · Pull Request #3244 · Automattic/simplenote-electron · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gconf2 dependency #3244

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Remove gconf2 dependency #3244

merged 1 commit into from
Aug 15, 2024

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Aug 8, 2024

Fix

This is an attempt to fix the issue reported by users who cannot install Simplenote on various Linux systems because the gconf2 dependency cannot be satisfied, #3241

The electron-builder docs mention that gconf2 can give issues if one wants to support KDE.

If need to support KDE, gconf2 and gconf-service should be removed as it’s no longer used by GNOME.

Moreover, the gconf2 entry in the Debian packages repository states:

This package is for legacy applications and no longer used by GNOME.

Given the above, this PR is an attempt to see what the app would do without the dependency. My guess is that everything should run fine in most modern systems, because all information points to gconf2 not being in use there.

Test

To test this we'll need to download the artifacts from CI and try to install them on Linux distros. If it works on our end, it might be good to reach out to the users in #3241 and see how they go.

This is an attempt to fix the issue reported by users who cannot install
Simplenote on various Linux systems because the `gconf2` dependency
cannot be satisfied. See
#3241

The [`electron-builder` docs](https://www.electron.build/configuration/linux.html)
mention that `gconf2` can give issues if one wants to support
[KDE](https://kde.org/).

> If need to support KDE, `gconf2` and `gconf-service` should be removed
> as it’s no longer used
> [by GNOME](https://packages.debian.org/bullseye/gconf2).

Moreover,
[the `gconf2` entry in the Debian packages repository](https://packages.debian.org/bullseye/gconf2)
states:

> This package is for legacy applications and no longer used by GNOME.

Given the above, this PR is an attempt to see what the app would do
without the dependency. My guess is that everything should run fine in
most modern systems, because all information points to `gconf2` not
being in use there.
@mokagio
Copy link
Contributor Author

mokagio commented Aug 9, 2024

All the Linux binaries have been built, which is already a good sign. I didn't have the time to set up VMs, but I plan to do so next week.

In the meantime pinging @codebykat and @roundhill in case you have access and bandwidth.

@codebykat
Copy link
Member

This got lost in the Slack backlog, noting @roundhill was able to successfully test this on Fedora in an arm64 VM.

@codebykat
Copy link
Member

Hmm. We can't share the build artifacts from Buildkite, they require a login. I'm going to merge this in hopes of getting a testable beta.

@codebykat codebykat marked this pull request as ready for review August 15, 2024 20:58
@codebykat codebykat merged commit d17e6da into trunk Aug 15, 2024
7 checks passed
@codebykat codebykat deleted the mokagio/remove-gconf2 branch August 15, 2024 20:58
@mokagio
Copy link
Contributor Author

mokagio commented Aug 16, 2024

I'm going to merge this in hopes of getting a testable beta.

👍

mokagio added a commit that referenced this pull request Aug 16, 2024
This is an attempt to fix the issue reported by users who cannot install
Simplenote on various Linux systems because the `gconf2` dependency
cannot be satisfied. See
#3241

The [`electron-builder` docs](https://www.electron.build/configuration/linux.html)
mention that `gconf2` can give issues if one wants to support
[KDE](https://kde.org/).

> If need to support KDE, `gconf2` and `gconf-service` should be removed
> as it’s no longer used
> [by GNOME](https://packages.debian.org/bullseye/gconf2).

Moreover,
[the `gconf2` entry in the Debian packages repository](https://packages.debian.org/bullseye/gconf2)
states:

> This package is for legacy applications and no longer used by GNOME.

Given the above, this PR is an attempt to see what the app would do
without the dependency. My guess is that everything should run fine in
most modern systems, because all information points to `gconf2` not
being in use there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants