1928868 - Adjust maxRecentMessageIDsPerSubscription to a higher value
Closed Bug 1928868 Opened 21 days ago Closed 19 days ago

Adjust maxRecentMessageIDsPerSubscription to a higher value

Categories

(Core :: DOM: Push Subscriptions, task)

Product:
Core
Component:
DOM: Push Subscriptions
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
134 Branch
Tracking Flags:
Tracking Status
firefox132 --- fixed
firefox133 --- fixed
firefox134 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

Attachments

(3 files)

Bug 1928868 - Adjust maxRecentMessageIDsPerSubscription to 100 r=asuth
48 bytes, text/x-phabricator-request
Details | Review
Bug 1928868 - Adjust maxRecentMessageIDsPerSubscription to 100 r=asuth
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review
Bug 1928868 - Adjust maxRecentMessageIDsPerSubscription to 100 r=asuth
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-release+
Details | Review

Given users are suffering from repeated notifications, having higher maxRecentMessageIDsPerSubscription should at least prevent repeatedly pinging service worker.

(Probably the initial implementation didn't expect that notifications will be sent much more frequently in 2024)

Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6f0b991fdf6b Adjust maxRecentMessageIDsPerSubscription to 100 r=asuth

https://hg.mozilla.org/mozilla-central/rev/6f0b991fdf6b

Status: ASSIGNED → RESOLVED
Closed: 19 days ago
status-firefox134: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
Attachment #9435844 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: Push clients will have less chance to detect duplicates, meaning more duplicated notifications shown to users.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: None, unclear how to reproduce the error.
  • Risk associated with taking this patch: Low
  • Explanation of risk level: only pref change
  • String changes made/needed: None
  • Is Android affected?: no
Attachment #9435845 - Flags: approval-mozilla-release?
Attachment #9435844 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9435845 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: