1928798 - High volume of startup errors for the external state machine
Closed Bug 1928798 Opened 22 days ago Closed 21 days ago

High volume of startup errors for the external state machine

Categories

(Core :: Audio/Video: Playback, defect, P1)

defect

Tracking

()

RESOLVED FIXED
134 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox132 + fixed
firefox133 + fixed
firefox134 + fixed

People

(Reporter: alwu, Assigned: alwu)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

From our dashboard, we've seen high volume of errors happened on the external state machine, I guess that there are something wrong for the mechanism of switching external state machine back to the normal state machine.

Set release status flags based on info from the regressing bug 1919627

Severity: -- → S2
Priority: -- → P1

It's possible that the initialization fail is caused by the users'
device don't support the media engine pipeline. In this case, we should
try to use the another state machine for playback, instead of just error
out.

Depends on D227772

Blocks: 1928828
Attachment #9434976 - Attachment description: Bug 1928798 - part2 : do not return fatal error if the initialization failed, try again with another state machine. → Bug 1928798 - do not return fatal error if the initialization failed, try again with another state machine.

Comment on attachment 9434975 [details]
Bug 1928798 - part1 : don't use ExternalEngineStateMachine if we already know the custom ident is used for non-supported CDM.

Revision D227772 was moved to bug 1928828. Setting attachment 9434975 [details] to obsolete.

Attachment #9434975 - Attachment is obsolete: true
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/733297b358c7 do not return fatal error if the initialization failed, try again with another state machine. r=jrmuizel

Comment on attachment 9434976 [details]
Bug 1928798 - do not return fatal error if the initialization failed, try again with another state machine.

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: Widevine L3 playback might be failed for some Windows users, due to their device capabilities
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No any new feature added or big structure change, we just change the internal returned error code to prevent the playback failed.
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9434976 - Flags: approval-mozilla-release?
Attachment #9434976 - Flags: approval-mozilla-beta?

We will be able to monitor this dashboard to see if the issue is fixed or not.

Status: NEW → RESOLVED
Closed: 21 days ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch

Comment on attachment 9434976 [details]
Bug 1928798 - do not return fatal error if the initialization failed, try again with another state machine.

Approved for 133.0b4

Attachment #9434976 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9434976 [details]
Bug 1928798 - do not return fatal error if the initialization failed, try again with another state machine.

Approved for 132.0.1.

Attachment #9434976 - Flags: approval-mozilla-release? → approval-mozilla-release+

Is manual testing needed for this bug? If yes, are there any specific steps we could use to manually verify this issue or would simply playing Netflix or other videos that use the Widevine plugin be sufficient?

Flags: needinfo?(alwu)
Blocks: mfcdm
Flags: needinfo?(alwu)
See Also: → 1929251
Blocks: 1929491
See Also: 1929251
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: