Feature #10958: remove "initial_state" argument of Enumerable#{slice_before,chunk} - Ruby master - Ruby Issue Tracking System

Project

General

Profile

Actions
Copy link

Feature #10958

closed

remove "initial_state" argument of Enumerable#{slice_before,chunk}

Added by akr (Akira Tanaka) over 9 years ago. Updated over 9 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:<unknown>]

Description

I'd like to remove "initial_state" argument of Enumerable#{slice_before,chunk}.

I think a state management can be implemented using local variable without the argument.
So I'd like to remove it because it is too complex and
not consistent with Enumerable#{slice_when,slice_after} which doesn't have the argument.

Note that I added deprecated warning since Ruby 2.2.
It seems no one complained the warning until now.

Files

chunk_slice_before_remove_initial_state.patch (8 KB) chunk_slice_before_remove_initial_state.patch akr (Akira Tanaka), 03/10/2015 12:48 PM

Related issues 1 (0 open — 1 closed)

Related to Ruby master - Bug #13202: Enumerable#slice_before does not take both argument and block at the same time, as it ought to.ClosedActions
Actions
Copy link
 #1

Updated by Eregon (Benoit Daloze) over 9 years ago

+1, making these two simpler is definitely an improvement!

Actions
Copy link
 #2

Updated by akr (Akira Tanaka) over 9 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r50174.

  • enum.c: Enumerable#chunk and Enumerable#slice_before no longer takes
    the initial_state argument. [Feature #10958]
Actions
Copy link
 #3

Updated by akr (Akira Tanaka) over 9 years ago

It seems no one against this. I committed.

Actions
Copy link
 #4

Updated by naruse (Yui NARUSE) almost 8 years ago

  • Related to Bug #13202: Enumerable#slice_before does not take both argument and block at the same time, as it ought to. added
Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0Like0