Debian Bug report logs - #1074828
atril: ftbfs with GCC-14

Reply or subscribe to this bug.

Display info messages

Message #5 received at maintonly@bugs.debian.org (full text, mbox, reply):

From: Matthias Klose <doko@debian.org>

To: maintonly@bugs.debian.org

Subject: atril: ftbfs with GCC-14

Date: Wed, 03 Jul 2024 12:22:26 +0000

Package: src:atril
Version: 1.26.2-3
Severity: important
Tags: sid trixie
User: debian-gcc@lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/atril_1.26.2-3_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
/bin/bash ../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../..  -Wall -Wmissing-prototypes  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o unzip.lo unzip.c
/bin/bash ../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../..  -Wall -Wmissing-prototypes  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o ioapi.lo ioapi.c
git.mk: Generating .gitignore
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../.. -Wall -Wmissing-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c ioapi.c  -fPIC -DPIC -o .libs/ioapi.o
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../.. -Wall -Wmissing-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c unzip.c  -fPIC -DPIC -o .libs/unzip.o
/bin/bash ../../../libtool  --tag=CC   --mode=link gcc  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection  -Wl,-z,relro -Wl,-z,now -o libminizip.la  unzip.lo ioapi.lo -lz  -lm 
libtool: link: ar cr .libs/libminizip.a .libs/unzip.o .libs/ioapi.o 
libtool: link: ranlib .libs/libminizip.a
libtool: link: ( cd ".libs" && rm -f "libminizip.la" && ln -s "../libminizip.la" "libminizip.la" )
make[5]: Leaving directory '/<<PKGBUILDDIR>>/backend/epub/minizip'
make[5]: Entering directory '/<<PKGBUILDDIR>>/backend/epub'
/bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../..  -I../.. -I../../libdocument -I./minizip -DMATELOCALEDIR=\"/usr/share/locale\" -DATRIL_COMPILATION -I/usr/include/cairo -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/harfbuzz -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -pthread  -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE  -Wall -Wmissing-prototypes -I/usr/include/webkitgtk-4.1 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/libsoup-3.0 -pthread -I/usr/include/libxml2   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o epub-document.lo epub-document.c
/usr/bin/msgfmt --desktop --keyword=TypeDescription --template epubdocument.atril-backend.desktop.in -d ../../po -o epubdocument.atril-backend
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../../libdocument -I./minizip -DMATELOCALEDIR=\"/usr/share/locale\" -DATRIL_COMPILATION -I/usr/include/cairo -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/harfbuzz -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -pthread -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE -Wall -Wmissing-prototypes -I/usr/include/webkitgtk-4.1 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/libsoup-3.0 -pthread -I/usr/include/libxml2 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c epub-document.c  -fPIC -DPIC -o .libs/epub-document.o
In file included from epub-document.c:36:
/usr/include/glib-2.0/glib/gi18n.h:28:10: warning: "_" redefined
   28 | #define  _(String) gettext (String)
      |          ^
In file included from ../../libdocument/ev-document.h:31,
                 from epub-document.h:5,
                 from epub-document.c:23:
/usr/include/glib-2.0/glib/gi18n-lib.h:32:10: note: this is the location of the previous definition
   32 | #define  _(String) ((char *) g_dgettext (GETTEXT_PACKAGE, String))
      |          ^
/usr/include/glib-2.0/glib/gi18n.h:29:9: warning: "Q_" redefined
   29 | #define Q_(String) g_dpgettext (NULL, String, 0)
      |         ^~
/usr/include/glib-2.0/glib/gi18n-lib.h:33:9: note: this is the location of the previous definition
   33 | #define Q_(String) g_dpgettext (GETTEXT_PACKAGE, String, 0)
      |         ^~
/usr/include/glib-2.0/glib/gi18n.h:31:9: warning: "C_" redefined
   31 | #define C_(Context,String) g_dpgettext (NULL, Context "\004" String, strlen (Context) + 1)
      |         ^~
/usr/include/glib-2.0/glib/gi18n-lib.h:35:9: note: this is the location of the previous definition
   35 | #define C_(Context,String) g_dpgettext (GETTEXT_PACKAGE, Context "\004" String, strlen (Context) + 1)
      |         ^~
epub-document.c: In function ‘check_mime_type’:
epub-document.c:635:40: error: passing argument 1 of ‘g_strv_length’ from incompatible pointer type [-Wincompatible-pointer-types]
  635 |         for (i = 0; i < g_strv_length (mimetypes); i++) {
      |                                        ^~~~~~~~~
      |                                        |
      |                                        const gchar ** {aka const char **}
In file included from /usr/include/glib-2.0/glib/gstring.h:37,
                 from /usr/include/glib-2.0/glib/giochannel.h:36,
                 from /usr/include/glib-2.0/glib.h:56,
                 from /usr/include/glib-2.0/glib/gi18n-lib.h:23:
/usr/include/glib-2.0/glib/gstrfuncs.h:383:55: note: expected ‘gchar **’ {aka ‘char **’} but argument is of type ‘const gchar **’ {aka ‘const char **’}
  383 | guint                 g_strv_length    (gchar       **str_array);
      |                                         ~~~~~~~~~~~~~~^~~~~~~~~
epub-document.c:646:48: error: passing argument 1 of ‘g_strv_length’ from incompatible pointer type [-Wincompatible-pointer-types]
  646 |                 for (i = 0; i < g_strv_length (mimetypes); i++) {
      |                                                ^~~~~~~~~
      |                                                |
      |                                                const gchar ** {aka const char **}
/usr/include/glib-2.0/glib/gstrfuncs.h:383:55: note: expected ‘gchar **’ {aka ‘char **’} but argument is of type ‘const gchar **’ {aka ‘const char **’}
  383 | guint                 g_strv_length    (gchar       **str_array);
      |                                         ~~~~~~~~~~~~~~^~~~~~~~~
make[5]: *** [Makefile:640: epub-document.lo] Error 1
make[5]: Leaving directory '/<<PKGBUILDDIR>>/backend/epub'
make[4]: *** [Makefile:676: all-recursive] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/backend/epub'
make[3]: *** [Makefile:500: all-recursive] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/backend'
make[2]: *** [Makefile:668: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:554: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:16: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

Message #14 received at 1074828@bugs.debian.org (full text, mbox, reply):

From: Andreas Rönnquist <gusnan@debian.org>

To: 1074828@bugs.debian.org

Subject: atril: ftbfs with GCC-14

Date: Sat, 10 Aug 2024 22:08:05 +0200

[Message part 1 (text/plain, inline)]

Control: tags 1074828 + patch

I don't know if there's a fix upstream, but the attached patch seems to fix
this build problem.

/Andreas Rönnquist
gusnan@debian.org

[1003-Cast-mimetypes-to-gchar-to-fix-building-on-gcc-14.patch (text/x-patch, attachment)]

Message #21 received at 1074828@bugs.debian.org (full text, mbox, reply):

From: Philip Chung <philipchung1995@yahoo.com>

To: Debian Bug Tracking System <1074828@bugs.debian.org>

Subject: Re: atril: ftbfs with GCC-14

Date: Mon, 12 Aug 2024 08:35:10 -0700

On Wed, 03 Jul 2024 12:22:26 +0000 Matthias Klose <doko@debian.org> wrote:
> The package fails to build in a test rebuild on at least amd64 with
> gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
> severity of this report will be raised before the trixie release.
> 
> [...]
> 
> epub-document.c: In function ‘check_mime_type’:
> epub-document.c:635:40: error: passing argument 1 of ‘g_strv_length’ from incompatible pointer type [-Wincompatible-pointer-types]
>   635 |         for (i = 0; i < g_strv_length (mimetypes); i++) {
>       |                                        ^~~~~~~~~
>       |                                        |
>       |                                        const gchar ** {aka const char **}
> In file included from /usr/include/glib-2.0/glib/gstring.h:37,
>                  from /usr/include/glib-2.0/glib/giochannel.h:36,
>                  from /usr/include/glib-2.0/glib.h:56,
>                  from /usr/include/glib-2.0/glib/gi18n-lib.h:23:
> /usr/include/glib-2.0/glib/gstrfuncs.h:383:55: note: expected ‘gchar **’ {aka ‘char **’} but argument is of type ‘const gchar **’ {aka ‘const char **’}
>   383 | guint                 g_strv_length    (gchar       **str_array);
>       |                                         ~~~~~~~~~~~~~~^~~~~~~~~
> epub-document.c:646:48: error: passing argument 1 of ‘g_strv_length’ from incompatible pointer type [-Wincompatible-pointer-types]
>   646 |                 for (i = 0; i < g_strv_length (mimetypes); i++) {
>       |                                                ^~~~~~~~~
>       |                                                |
>       |                                                const gchar ** {aka const char **}
> /usr/include/glib-2.0/glib/gstrfuncs.h:383:55: note: expected ‘gchar **’ {aka ‘char **’} but argument is of type ‘const gchar **’ {aka ‘const char **’}
>   383 | guint                 g_strv_length    (gchar       **str_array);
>       |                                         ~~~~~~~~~~~~~~^~~~~~~~~

This is fixed upstream in version 1.27.1, first in a GitHub pull request
[1] and later in a separate commit [2]. (The second instance of the
error is fixed using a different approach although I'd argue it makes
more sense to use the same approach as for the first errror.)

Philip Chung

[1] https://github.com/mate-desktop/atril/pull/604
[2]
https://github.com/mate-desktop/atril/commit/6d37d813914c5a466b0859348cce4d64781b2a

Message #28 received at 1074828@bugs.debian.org (full text, mbox, reply):

From: Andreas Rönnquist <gusnan@debian.org>

To: 1074828@bugs.debian.org, Philip Chung <philipchung1995@yahoo.com>

Subject: Re: atril: ftbfs with GCC-14

Date: Sat, 28 Sep 2024 18:51:18 +0200

On Mon, 12 Aug 2024 08:35:10 -0700 Philip Chung <philipchung1995@yahoo.com> wrote:
> On Wed, 03 Jul 2024 12:22:26 +0000 Matthias Klose <doko@debian.org> wrote:
> 
> This is fixed upstream in version 1.27.1, first in a GitHub pull request
> [1] and later in a separate commit [2]. (The second instance of the
> error is fixed using a different approach although I'd argue it makes
> more sense to use the same approach as for the first errror.)
> 
> Philip Chung
> 
> [1] https://github.com/mate-desktop/atril/pull/604
> [2]
> https://github.com/mate-desktop/atril/commit/6d37d813914c5a466b0859348cce4d64781b2a
> 
> 

I'm of course fine with either way - the maintainers know better than
me what is the best solution, and since there's a new upstream version
that would of course be lovely to have that packaged. I'm kinda
surprised to see that the new hasn't been packaged yet (and has gotten
removed from testing because of this bug), since the package looks like
it's team-maintained, and has 5 (!) people in the uploader field.

/Andreas

Message #33 received at 1074828@bugs.debian.org (full text, mbox, reply):

From: john faulk <mrjohnnywfaulk@gmail.com>

To: 1074828@bugs.debian.org

Cc: code@flexion.org, code@wimpress.io, martin.wimpress@ubuntu.com

Subject: Atril Bug

Date: Fri, 25 Oct 2024 08:25:52 -0500

I am CCing one of the maintainers, so that they can see this, as it
affects both Debian and likely ubuntu MATE as well.

-John

Send a report that this bug log contains spam.