-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Contributor License Agreement sign up page listed Taiwan erroneously #8337
Comments
+1 Taiwan is not a part of China! |
+1 Republic of China is the official name. |
Taiwan DOES NOT belonged to China |
@tan9 nice catch, thanks for pointing that out. |
+1 Taiwan is not a part of China! |
It looks like we got the country name list from ISO_3166-1, which lists the name this way. Other projects using the ISO country list have apparently encountered this as an issue too -- StackOverflow changed it to just plain "Taiwan" in their case. Seems simple enough for us to do the same. |
@peterflynn , thank you! Plain "Taiwan" is OK for most of us, if Republic of China is not available. The usage of Republic of China may cause unnecessary flaming war form some irrational people behind the Great Firewall of China. |
Changed the agreement to use "Taiwan". The update is now immediately available in the Country drop-down at http://dev.brackets.io/brackets-contributor-license-agreement.html. Thanks for catching this, @tan9 |
@bchintx thanks a lot! I can confirm that the CLA page has been updated. |
Great. Thanks @tan9. |
http://dev.brackets.io/brackets-contributor-license-agreement.html listed Taiwan as "Taiwan, Province of China", this is incorrect!
http://en.wikipedia.org/wiki/Taiwan, officially the Republic of China, is a STATE in East Asia. Not a part of P.R.C.!
The text was updated successfully, but these errors were encountered: