Contributor License Agreement sign up page listed Taiwan erroneously · Issue #8337 · adobe/brackets · GitHub
Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Contributor License Agreement sign up page listed Taiwan erroneously #8337

Closed
tan9 opened this issue Jul 8, 2014 · 10 comments
Closed

Contributor License Agreement sign up page listed Taiwan erroneously #8337

tan9 opened this issue Jul 8, 2014 · 10 comments
Assignees

Comments

@tan9
Copy link
Contributor

tan9 commented Jul 8, 2014

http://dev.brackets.io/brackets-contributor-license-agreement.html listed Taiwan as "Taiwan, Province of China", this is incorrect!

http://en.wikipedia.org/wiki/Taiwan, officially the Republic of China, is a STATE in East Asia. Not a part of P.R.C.!

@jenghung
Copy link

jenghung commented Jul 8, 2014

+1 Taiwan is not a part of China!

@Sparkisgood
Copy link

+1 Republic of China is the official name.

@orioleHsu
Copy link

Taiwan DOES NOT belonged to China

@larz0
Copy link
Member

larz0 commented Jul 8, 2014

@tan9 nice catch, thanks for pointing that out.

@ropin13
Copy link

ropin13 commented Jul 8, 2014

+1 Taiwan is not a part of China!

@peterflynn
Copy link
Member

It looks like we got the country name list from ISO_3166-1, which lists the name this way. Other projects using the ISO country list have apparently encountered this as an issue too -- StackOverflow changed it to just plain "Taiwan" in their case. Seems simple enough for us to do the same.

@tan9
Copy link
Contributor Author

tan9 commented Jul 8, 2014

@peterflynn , thank you! Plain "Taiwan" is OK for most of us, if Republic of China is not available.

The usage of Republic of China may cause unnecessary flaming war form some irrational people behind the Great Firewall of China.

@bchintx bchintx self-assigned this Jul 8, 2014
@bchintx
Copy link
Contributor

bchintx commented Jul 8, 2014

Changed the agreement to use "Taiwan". The update is now immediately available in the Country drop-down at http://dev.brackets.io/brackets-contributor-license-agreement.html.

Thanks for catching this, @tan9

@bchintx bchintx closed this as completed Jul 8, 2014
@tan9
Copy link
Contributor Author

tan9 commented Jul 8, 2014

@bchintx thanks a lot! I can confirm that the CLA page has been updated.

@bchintx
Copy link
Contributor

bchintx commented Jul 8, 2014

Great. Thanks @tan9.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants